aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Opalach <ado92300@gmail.com>2019-04-22 15:50:07 -0400
committerChristian Duerr <chrisduerr@users.noreply.github.com>2019-04-22 19:50:07 +0000
commitc901c74d017a89e8196976e4f515960a5219c2cf (patch)
tree17777632571b8a2f9f7bb813e1e12bae63b80a84
parent2b39e6bf99324c0fc2d3600075b0cafd57af036c (diff)
downloadalacritty-c901c74d017a89e8196976e4f515960a5219c2cf.tar.gz
alacritty-c901c74d017a89e8196976e4f515960a5219c2cf.zip
Fix ConPTY panic
-rw-r--r--CHANGELOG.md6
-rw-r--r--src/tty/windows/conpty.rs8
2 files changed, 10 insertions, 4 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index cbaaa515..d5f20f07 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+## [Unreleased]
+
+### Fixed
+
+- Panic on startup when using Conpty on Windows
+
## Version 0.3.1
### Added
diff --git a/src/tty/windows/conpty.rs b/src/tty/windows/conpty.rs
index 605829d6..f23d78a7 100644
--- a/src/tty/windows/conpty.rs
+++ b/src/tty/windows/conpty.rs
@@ -160,7 +160,7 @@ pub fn new<'a>(
InitializeProcThreadAttributeList(ptr::null_mut(), 1, 0, &mut size as PSIZE_T) > 0;
// This call was expected to return false.
- if (!failure) {
+ if failure {
panic_shell_spawn();
}
}
@@ -186,7 +186,7 @@ pub fn new<'a>(
&mut size as PSIZE_T,
) > 0;
- if (!success) {
+ if !success {
panic_shell_spawn();
}
}
@@ -203,7 +203,7 @@ pub fn new<'a>(
ptr::null_mut(),
) > 0;
- if (!success) {
+ if !success {
panic_shell_spawn();
}
}
@@ -238,7 +238,7 @@ pub fn new<'a>(
&mut proc_info as *mut PROCESS_INFORMATION,
) > 0;
- if (!success) {
+ if !success {
panic_shell_spawn();
}
}