aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Duerr <contact@christianduerr.com>2021-02-27 15:06:22 +0000
committerGitHub <noreply@github.com>2021-02-27 15:06:22 +0000
commitedfcb81339ddb1af165c6293229a98b588a90af9 (patch)
treee593588fe221cb22ba82765d2920840e0650f536
parent72b341425d8a27026d9dde00519a84f1a6b85bb9 (diff)
downloadalacritty-edfcb81339ddb1af165c6293229a98b588a90af9.tar.gz
alacritty-edfcb81339ddb1af165c6293229a98b588a90af9.zip
Run clippy on MSRV
Since not all suggested clippy lints by stable clippy are supported on the MSRV of Alacritty, this commit moves the clippy checks to the MSRV. Unfortunately this will mean that our lints might be significantly behind, however it ensures our CI never blocks any code that should be valid. Developers themselves of course can still run the latest clippy to follow the up to date recommendations.
-rw-r--r--.builds/freebsd.yml9
-rw-r--r--.builds/linux.yml13
-rw-r--r--.github/workflows/ci.yml8
-rw-r--r--CHANGELOG.md4
-rw-r--r--Cargo.lock2
5 files changed, 20 insertions, 16 deletions
diff --git a/.builds/freebsd.yml b/.builds/freebsd.yml
index ec2e1616..70ee6d43 100644
--- a/.builds/freebsd.yml
+++ b/.builds/freebsd.yml
@@ -21,14 +21,15 @@ tasks:
- test: |
cd alacritty
cargo test
+ - oldstable: |
+ cd alacritty
+ rustup toolchain install --profile minimal 1.45.2
+ rustup default 1.45.2
+ cargo test
- clippy: |
cd alacritty
rustup component add clippy
cargo clippy --all-targets
- - oldstable: |
- cd alacritty
- rustup toolchain install --profile minimal 1.43.1
- cargo +1.43.1 test
- feature-wayland: |
cd alacritty/alacritty
cargo test --no-default-features --features=wayland
diff --git a/.builds/linux.yml b/.builds/linux.yml
index 90c31836..3f793175 100644
--- a/.builds/linux.yml
+++ b/.builds/linux.yml
@@ -24,17 +24,18 @@ tasks:
cd alacritty
rustup toolchain install nightly -c rustfmt
cargo +nightly fmt -- --check
+ - oldstable: |
+ cd alacritty
+ rustup toolchain install --profile minimal 1.45.2
+ rustup default 1.45.2
+ cargo test
- clippy: |
cd alacritty
rustup component add clippy
cargo clippy --all-targets
- - oldstable: |
- cd alacritty
- rustup toolchain install --profile minimal 1.43.1
- cargo +1.43.1 test
- feature-wayland: |
cd alacritty/alacritty
- cargo +1.43.1 test --no-default-features --features=wayland
+ cargo test --no-default-features --features=wayland
- feature-x11: |
cd alacritty/alacritty
- cargo +1.43.1 test --no-default-features --features=x11
+ cargo test --no-default-features --features=x11
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 16fb8eb3..23379ab5 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -17,11 +17,11 @@ jobs:
- uses: actions/checkout@v2
- name: Stable
run: cargo test
+ - name: Oldstable
+ run: |
+ rustup default 1.45.2
+ cargo test
- name: Clippy
run: |
rustup component add clippy
cargo clippy --all-targets
- - name: Oldstable
- run: |
- rustup default 1.43.1
- cargo test
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 63d8c803..9333328b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
## 0.8.0-dev
+### Packaging
+
+- Minimum Rust version has been bumped to 1.45.0
+
### Added
- IME composition preview not appearing on Windows
diff --git a/Cargo.lock b/Cargo.lock
index 0fe0b632..505b64d2 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1,7 +1,5 @@
# This file is automatically @generated by Cargo.
# It is not intended for manual editing.
-version = 3
-
[[package]]
name = "ab_glyph_rasterizer"
version = "0.1.4"