summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKhinenw <deu07115@gmail.com>2021-01-15 17:48:30 +0900
committerGitHub <noreply@github.com>2021-01-15 08:48:30 +0000
commit3ed9f9ac388d142c4ad9ebba3a9fe6e17ccc3b0e (patch)
treef40f9d5cd02711acfac27187f295bf11e54ffff1
parent80f7adf20f1fcaf6323ea905095404de71bf98a2 (diff)
downloadalacritty-3ed9f9ac388d142c4ad9ebba3a9fe6e17ccc3b0e.tar.gz
alacritty-3ed9f9ac388d142c4ad9ebba3a9fe6e17ccc3b0e.zip
Add IME support for Windows
-rw-r--r--CHANGELOG.md4
-rw-r--r--alacritty/src/window.rs5
2 files changed, 4 insertions, 5 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9df5b3ee..ee95a3ce 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
## 0.8.0-dev
+### Added
+
+- IME composition preview not appearing on Windows
+
### Fixed
- Crash due to assertion failure on 32-bit architectures
diff --git a/alacritty/src/window.rs b/alacritty/src/window.rs
index 418994ed..3661d406 100644
--- a/alacritty/src/window.rs
+++ b/alacritty/src/window.rs
@@ -421,7 +421,6 @@ impl Window {
}
/// Adjust the IME editor position according to the new location of the cursor.
- #[cfg(not(windows))]
pub fn update_ime_position(&mut self, point: Point, size: &SizeInfo) {
let nspot_x = f64::from(size.padding_x() + point.col.0 as f32 * size.cell_width());
let nspot_y = f64::from(size.padding_y() + (point.line.0 + 1) as f32 * size.cell_height());
@@ -429,10 +428,6 @@ impl Window {
self.window().set_ime_position(PhysicalPosition::new(nspot_x, nspot_y));
}
- /// No-op, since Windows does not support IME positioning.
- #[cfg(windows)]
- pub fn update_ime_position(&mut self, _point: Point, _size_info: &SizeInfo) {}
-
pub fn swap_buffers(&self) {
self.windowed_context.swap_buffers().expect("swap buffers");
}