aboutsummaryrefslogtreecommitdiff
path: root/.github
diff options
context:
space:
mode:
authorJoe Wilm <joe@jwilm.com>2018-03-06 20:57:40 -0800
committerJoe Wilm <joe@jwilm.com>2018-03-07 09:51:51 -0800
commit143c28953cca8f2a1190c94f6e6944dad391dac7 (patch)
tree0eaa7794088041a37ef1e7c564926407c5c7eb56 /.github
parent2cfdd595f11377fbd91536a428e87d949ed9a05e (diff)
downloadalacritty-143c28953cca8f2a1190c94f6e6944dad391dac7.tar.gz
alacritty-143c28953cca8f2a1190c94f6e6944dad391dac7.zip
Support selections with scrolling buffer
Selections now *mostly* work. They move as the buffer scrolls, copying works as it should, and it looks like the different selection modes behave properly as well. The new Selection implementation uses buffer coordinates instead of screen coordinates. This leads to doing a transform from mouse input to update the selection, and back to screen coordinates when displaying the selection. Scrolling the selection is fast because the grid is already operating in buffer coordinates. There are several bugs to address: * A _partially_ visible selection will lead to a crash since the drawing routine converts selection coordinates to screen coordinates. The solution will be to clip the coordinates at draw time. * A selection scrolling off the buffer in either direction leads to indexing out-of-bounds. The solution again is to clip, but this needs to be done within Selection::rotate by passing a max limit. It may also need a return type to indicate that the selection is no longer visible and should be discarded. * A selection scrolling out of a logical scrolling region is not clipped. A temporary and robust workaround is to simply discard the selection in the case of scrolling in a region. wip selections fix issue with line selection selection mostly working need to support selection not being on the screen at draw time Fix selection_to_string Uncomment tests
Diffstat (limited to '.github')
0 files changed, 0 insertions, 0 deletions