diff options
| author | Christian Duerr <contact@christianduerr.com> | 2021-07-08 20:35:58 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-07-08 20:35:58 +0000 |
| commit | 8cb1acc27d863942401df80c3acb8b4016ad6083 (patch) | |
| tree | 5772b74e40235ef4e9367d33014646a36666e320 /.builds | |
| parent | 4a3bcdb49d2027d4cbf6a2f147b07da38a4b0238 (diff) | |
| download | alacritty-8cb1acc27d863942401df80c3acb8b4016ad6083.tar.gz alacritty-8cb1acc27d863942401df80c3acb8b4016ad6083.zip | |
Fix PTY performance regressions
The patch 9e7655e introduced some changes which improved rendering with
very dense grids, but the automatic benchmarks indicated a slight
performance difference in the `dense_cells` benchmark.
Caching the terminal lock between iterations rather than always calling
`try_lock` resolves that issue.
While breaking early in the `WouldBlock` case with `unprocessed != 0`
does also help resolve these issues, it shows some more significant
fluctuations. Combining both fixes does not help.
Additionally on Windows receiving `Ok(0)` from the PTY will also occur
instead of a `WouldBlock` error, so handling that fixes freezing on
Windows.
Fixes #5305.
Diffstat (limited to '.builds')
| -rw-r--r-- | .builds/freebsd.yml | 1 | ||||
| -rw-r--r-- | .builds/linux.yml | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/.builds/freebsd.yml b/.builds/freebsd.yml index 70ee6d43..b67d2672 100644 --- a/.builds/freebsd.yml +++ b/.builds/freebsd.yml @@ -8,6 +8,7 @@ packages: - x11-fonts/fontconfig - x11-fonts/dejavu - x11/libxcb + - x11/libxkbcommon sources: - https://github.com/alacritty/alacritty diff --git a/.builds/linux.yml b/.builds/linux.yml index 3f793175..dc107515 100644 --- a/.builds/linux.yml +++ b/.builds/linux.yml @@ -7,6 +7,7 @@ packages: - freetype2 - fontconfig - libxcb + - libxkbcommon sources: - https://github.com/alacritty/alacritty |