From 3591acba76d30ea7986ff5828cefcd7d8f705be2 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Tue, 8 Dec 2020 19:23:56 -0800 Subject: device: make test setup more robust Picking two free ports to use for a test is difficult. The free port we selected might no longer be free when we reach for it a second time. On my machine, this failure mode led to failures approximately once per thousand test runs. Since failures are rare, and threading through and checking for all possible errors is complicated, fix this with a big hammer: Retry if either device fails to come up. Also, if you accidentally pick the same port twice, delightful confusion ensues. The handshake failures manifest as crypto errors, which look scary. Again, fix with retries. To make these retries easier to implement, use testing.T.Cleanup instead of defer to close devices. This requires Go 1.14. Update go.mod accordingly. Go 1.13 is no longer supported anyway. With these fixes, 'go test -race' ran 100,000 times without failure. Signed-off-by: Josh Bleecher Snyder --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'go.mod') diff --git a/go.mod b/go.mod index 22e0b95..1dbdb67 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module golang.zx2c4.com/wireguard -go 1.13 +go 1.14 require ( golang.org/x/crypto v0.0.0-20201124201722-c8d3bf9c5392 -- cgit v1.2.3-54-g00ecf