From ecd718e116c3cb76ccea205c885d5d110bbe65bd Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Mon, 6 Feb 2023 15:04:46 +0000 Subject: Add `ed25519`, the name of the auth type, to the heading --- rend-spec-v3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rend-spec-v3.txt b/rend-spec-v3.txt index a8ac264..48d2ba3 100644 --- a/rend-spec-v3.txt +++ b/rend-spec-v3.txt @@ -2071,7 +2071,7 @@ Table of contents: One mechanism to do so is the credential mechanism, where only users who know the credential for a hidden service may connect at all. -3.4.1. Ed25519-based authentication. +3.4.1. Ed25519-based authentication `ed25519`. To authenticate with an Ed25519 private key, the user must include an extension field in the encrypted part of the INTRODUCE1 cell with an -- cgit v1.2.3-54-g00ecf From 51fd440a19f1e41931049b72aae2d3cca0697d0c Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Mon, 6 Feb 2023 15:06:41 +0000 Subject: Talk of "defined" rather than "recognized" auth types We're not the code, we're the spec. We can define things, not recognise them. --- rend-spec-v3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rend-spec-v3.txt b/rend-spec-v3.txt index 48d2ba3..b533895 100644 --- a/rend-spec-v3.txt +++ b/rend-spec-v3.txt @@ -1360,7 +1360,7 @@ Table of contents: A space-separated list of introduction-layer authentication types; see section [INTRO-AUTH] for more info. A client that does not support at least one of these authentication types will not be able to contact the - host. Recognized types are: 'password' and 'ed25519'. + host. Defined types are: 'password' and 'ed25519'. "single-onion-service" -- cgit v1.2.3-54-g00ecf From dc822431f3bf2d9a31d83662982cafbc2a6d4a38 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Mon, 6 Feb 2023 15:07:10 +0000 Subject: Properly define "authentication types" in the relevant section Use the phrase which is used elsehwer, and enumerate them again since this is where one would expect to find that enumeration. --- rend-spec-v3.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rend-spec-v3.txt b/rend-spec-v3.txt index b533895..33415e4 100644 --- a/rend-spec-v3.txt +++ b/rend-spec-v3.txt @@ -2071,6 +2071,8 @@ Table of contents: One mechanism to do so is the credential mechanism, where only users who know the credential for a hidden service may connect at all. + There are two defined authentication types, `ed25519` and `password`. + 3.4.1. Ed25519-based authentication `ed25519`. To authenticate with an Ed25519 private key, the user must include an -- cgit v1.2.3-54-g00ecf From 28cc4dc16b79ac31f2a3bfdc3a49387b1912c39b Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Mon, 6 Feb 2023 15:08:00 +0000 Subject: Mention, hopelessly, the undocumented "password" auth type --- rend-spec-v3.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rend-spec-v3.txt b/rend-spec-v3.txt index 33415e4..fb570b4 100644 --- a/rend-spec-v3.txt +++ b/rend-spec-v3.txt @@ -2073,6 +2073,9 @@ Table of contents: There are two defined authentication types, `ed25519` and `password`. + However, the `password` authentication type is not documented + and ??? ??? ???. + 3.4.1. Ed25519-based authentication `ed25519`. To authenticate with an Ed25519 private key, the user must include an -- cgit v1.2.3-54-g00ecf