From bfebc942eaf7098e8d35f1de9159da450d5e3969 Mon Sep 17 00:00:00 2001 From: Robert Ransom Date: Mon, 11 Apr 2011 02:26:07 -0700 Subject: Correct the warning emitted when rejecting an oversized HS desc --- src/or/routerparse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/or/routerparse.c') diff --git a/src/or/routerparse.c b/src/or/routerparse.c index 1faa177edf..28ecaf0ad7 100644 --- a/src/or/routerparse.c +++ b/src/or/routerparse.c @@ -3629,7 +3629,7 @@ rend_parse_v2_service_descriptor(rend_service_descriptor_t **parsed_out, /* Check length. */ if (strlen(desc) > REND_DESC_MAX_SIZE) { log_warn(LD_REND, "Descriptor length is %i which exceeds " - "maximum rendezvous descriptor size of %i kilobytes.", + "maximum rendezvous descriptor size of %i bytes.", (int)strlen(desc), REND_DESC_MAX_SIZE); goto err; } -- cgit v1.2.3-54-g00ecf From adc31001c2f9923f8fcee2141d233200c95373cf Mon Sep 17 00:00:00 2001 From: Robert Ransom Date: Mon, 18 Apr 2011 13:25:48 -0700 Subject: Add an XXX --- src/or/routerparse.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/or/routerparse.c') diff --git a/src/or/routerparse.c b/src/or/routerparse.c index 28ecaf0ad7..3d73f8de68 100644 --- a/src/or/routerparse.c +++ b/src/or/routerparse.c @@ -3628,6 +3628,8 @@ rend_parse_v2_service_descriptor(rend_service_descriptor_t **parsed_out, eos = eos + 1; /* Check length. */ if (strlen(desc) > REND_DESC_MAX_SIZE) { + /* XXX023 If we are parsing this descriptor as a server, this + * should be a protocol warning. */ log_warn(LD_REND, "Descriptor length is %i which exceeds " "maximum rendezvous descriptor size of %i bytes.", (int)strlen(desc), REND_DESC_MAX_SIZE); -- cgit v1.2.3-54-g00ecf