From 1c475eb018989f090c1423c25dc2f09380b10693 Mon Sep 17 00:00:00 2001 From: George Kadianakis Date: Mon, 10 Mar 2014 22:52:07 +0000 Subject: Throw control port warning if we failed to connect to all our bridges. --- src/or/control.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'src/or/control.c') diff --git a/src/or/control.c b/src/or/control.c index 05ff9a6592..48f9b57d93 100644 --- a/src/or/control.c +++ b/src/or/control.c @@ -4873,10 +4873,12 @@ control_event_bootstrap(bootstrap_status_t status, int progress) /** Called when Tor has failed to make bootstrapping progress in a way * that indicates a problem. warn gives a hint as to why, and - * reason provides an "or_conn_end_reason" tag. + * reason provides an "or_conn_end_reason" tag. or_conn + * is the connection that caused this problem. */ MOCK_IMPL(void, -control_event_bootstrap_problem, (const char *warn, int reason)) + control_event_bootstrap_problem, (const char *warn, int reason, + const or_connection_t *or_conn)) { int status = bootstrap_percent; const char *tag, *summary; @@ -4898,9 +4900,10 @@ control_event_bootstrap_problem, (const char *warn, int reason)) if (reason == END_OR_CONN_REASON_NO_ROUTE) recommendation = "warn"; - if (get_options()->UseBridges && - !any_bridge_descriptors_known() && - !any_pending_bridge_descriptor_fetches()) + /* If we are using bridges and all our OR connections are now + closed, it means that we totally failed to connect to our + bridges. Throw a warning. */ + if (get_options()->UseBridges && !any_other_active_or_conns(or_conn)) recommendation = "warn"; if (we_are_hibernating()) -- cgit v1.2.3-54-g00ecf