From 063ced890373c1327b521ffc2481f609c58ea4d7 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Thu, 21 Feb 2008 04:30:14 +0000 Subject: r18296@catbus: nickm | 2008-02-20 23:30:11 -0500 Answer one xxx020 item; move 7 other ones to a new "XXX020rc" category: they should get fixed before we cut a release candidate. arma: please review these to see whether you have fixes/answers for any. Please check out the other 14 XXX020s to see if any look critical for the release candidate. svn:r13640 --- src/or/command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/or/command.c') diff --git a/src/or/command.c b/src/or/command.c index 5da9316f18..66723d4dd0 100644 --- a/src/or/command.c +++ b/src/or/command.c @@ -478,7 +478,8 @@ command_process_versions_cell(var_cell_t *cell, or_connection_t *conn) connection_mark_for_close(TO_CONN(conn)); return; } else if (highest_supported_version == 1) { - /*XXXXX020 consider this carefully. */ + /* Negotiating version 1 makes no sense, since version 1 has no VERSIONS + * cells. */ log_fn(LOG_PROTOCOL_WARN, LD_OR, "Used version negotiation protocol to negotiate a v1 connection. " "That's crazily non-compliant. Closing connection."); -- cgit v1.2.3-54-g00ecf