From 02c2d9a4aa2a7ce339e87be9c0c0dc23a6881c14 Mon Sep 17 00:00:00 2001
From: Robert Hogan <robert@roberthogan.net>
Date: Tue, 14 Dec 2010 19:59:42 +0000
Subject: bug1666 - Pass-through support for SOCKS5 authentication(4)

Implement nickm's suggestion that we tolerate SOCKS5 clients
that send authentication credentials and SOCKS commands all in
one go.
---
 src/or/buffers.c | 5 -----
 1 file changed, 5 deletions(-)

(limited to 'src/or/buffers.c')

diff --git a/src/or/buffers.c b/src/or/buffers.c
index 5cd76fa0d6..445376f60e 100644
--- a/src/or/buffers.c
+++ b/src/or/buffers.c
@@ -1658,11 +1658,6 @@ parse_socks(const char *data, size_t datalen, socks_request_t *req,
         *want_length_out = 2u+usernamelen;
         return 0;
       }
-      if (datalen > 2u + usernamelen + 1u + passlen) {
-        log_warn(LD_APP,
-                 "socks5: Malformed username/password. Rejecting.");
-        return -1;
-      }
       req->replylen = 2; /* 2 bytes of response */
       req->reply[0] = 5;
       req->reply[1] = 0; /* authentication successful */
-- 
cgit v1.2.3-54-g00ecf