From d91ad5112e91bfed59bebb657feacac64d34494f Mon Sep 17 00:00:00 2001 From: Tobias Stoeckmann Date: Wed, 10 Jul 2019 20:39:57 +0200 Subject: Check tor_vasprintf for error return values. In case of error, a negative value will be returned or NULL written into first supplied argument. This patch uses both cases to comply with style in the specific files. A tor_vasprintf error in process_vprintf would lead to a NULL dereference later on in buf_add, because the return value -1 casted to size_t would pass an assertion check inside of buf_add. On the other hand, common systems will fail on such an operation, so it is not a huge difference to a simple assertion. Yet it is better to properly fail instead of relying on such behaviour on all systems. Signed-off-by: Tobias Stoeckmann --- src/lib/buf/buffers.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/lib/buf/buffers.c') diff --git a/src/lib/buf/buffers.c b/src/lib/buf/buffers.c index 4d026bd37d..452bf74376 100644 --- a/src/lib/buf/buffers.c +++ b/src/lib/buf/buffers.c @@ -578,6 +578,7 @@ buf_add_vprintf(buf_t *buf, const char *format, va_list args) /* XXXX Faster implementations are easy enough, but let's optimize later */ char *tmp; tor_vasprintf(&tmp, format, args); + tor_assert(tmp != NULL); buf_add(buf, tmp, strlen(tmp)); tor_free(tmp); } -- cgit v1.2.3-54-g00ecf