From ce5e38642d1f5e48a7e5c98422e0fa23145f0363 Mon Sep 17 00:00:00 2001 From: teor Date: Fri, 5 Apr 2019 15:08:54 +1000 Subject: crypto_format: Remove the return value from ed25519_signature_to_base64() Also remove all checks for the return value, which were redundant anyway, because the function never failed. Part of 29660. --- src/feature/hs/hs_descriptor.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'src/feature/hs') diff --git a/src/feature/hs/hs_descriptor.c b/src/feature/hs/hs_descriptor.c index 2793597028..b526da6661 100644 --- a/src/feature/hs/hs_descriptor.c +++ b/src/feature/hs/hs_descriptor.c @@ -1082,11 +1082,7 @@ desc_encode_v3(const hs_descriptor_t *desc, tor_free(encoded_str); goto err; } - if (ed25519_signature_to_base64(ed_sig_b64, &sig) < 0) { - log_warn(LD_BUG, "Can't base64 encode descriptor signature!"); - tor_free(encoded_str); - goto err; - } + ed25519_signature_to_base64(ed_sig_b64, &sig); /* Create the signature line. */ smartlist_add_asprintf(lines, "%s %s", str_signature, ed_sig_b64); } -- cgit v1.2.3-54-g00ecf