From 26c069089b3ec5a0f278e5922b643de455f36af0 Mon Sep 17 00:00:00 2001 From: David Goulet Date: Mon, 21 Oct 2024 12:03:54 -0400 Subject: Revert "Handle empty DNS reply without error as NOERROR" Closes #40984 This reverts commit 3d2f7c3467e7aff545d8e22ffd4153d7598c6d7c. --- src/feature/client/dnsserv.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/feature/client/dnsserv.c') diff --git a/src/feature/client/dnsserv.c b/src/feature/client/dnsserv.c index 237a6ee3d3..f0bb0af100 100644 --- a/src/feature/client/dnsserv.c +++ b/src/feature/client/dnsserv.c @@ -319,7 +319,6 @@ evdns_get_orig_address(const struct evdns_server_request *req, break; case RESOLVED_TYPE_ERROR: case RESOLVED_TYPE_ERROR_TRANSIENT: - case RESOLVED_TYPE_NOERROR: /* Addr doesn't matter, since we're not sending it back in the reply.*/ return addr; default: @@ -380,8 +379,6 @@ dnsserv_resolved(entry_connection_t *conn, tor_free(ans); } else if (answer_type == RESOLVED_TYPE_ERROR) { err = DNS_ERR_NOTEXIST; - } else if (answer_type == RESOLVED_TYPE_NOERROR) { - err = DNS_ERR_NONE; } else { /* answer_type == RESOLVED_TYPE_ERROR_TRANSIENT */ err = DNS_ERR_SERVERFAILED; } -- cgit v1.2.3-54-g00ecf