From 6c432a5565183b705569310a34b4da54b1bf98d4 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Tue, 9 Sep 2008 19:29:33 +0000 Subject: Replace the dummy-use var in SMARTLIST_FOREACH_END() with one that is less likely to confuse analysis tools into thinking we do use after free. Arguably, (void)x should count as use in suppressing unused variable warnings, but not in generating hey-you-used-a-variable warnings. Arguably, though, it shouldn't. svn:r16815 --- src/common/container.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/common/container.h') diff --git a/src/common/container.h b/src/common/container.h index 598e27aaa5..0a790ea4ac 100644 --- a/src/common/container.h +++ b/src/common/container.h @@ -204,7 +204,7 @@ char *smartlist_join_strings2(smartlist_t *sl, const char *join, var = (sl)->list[var ## _sl_idx]; #define SMARTLIST_FOREACH_END(var) \ - (void)var; \ + var = NULL; \ } STMT_END #define SMARTLIST_FOREACH(sl, type, var, cmd) \ -- cgit v1.2.3-54-g00ecf