From 558aaf1c32ece99f62006c6a3395c3e53d5e414d Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Mon, 7 Dec 2020 16:40:19 -0500 Subject: Command-line arguments: be better at detecting absent optional args. Previously, "--list-fingerprint --quiet" was an error. Now, the handler for optional arguments to "--list-fingerprint" can tell that "--quiet" is a flag, not an argument. This only affects flags that take an _optional_ argument, so you can still put your torrc file in a location starting with "-". Closes #40223. --- src/app/config/config.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/app') diff --git a/src/app/config/config.c b/src/app/config/config.c index df89b6ede9..660c89bc4c 100644 --- a/src/app/config/config.c +++ b/src/app/config/config.c @@ -2601,8 +2601,11 @@ config_parse_commandline(int argc, char **argv, int ignore_errors) parsed_cmdline_free(result); return NULL; } - } else if (want_arg == ARGUMENT_OPTIONAL && is_last) { + } else if (want_arg == ARGUMENT_OPTIONAL && + /* optional arguments may never start with '-'. */ + (is_last || argv[i+1][0] == '-')) { arg = tor_strdup(""); + want_arg = ARGUMENT_NONE; // prevent skipping the next flag. } else { arg = (want_arg != ARGUMENT_NONE) ? tor_strdup(argv[i+1]) : tor_strdup(""); -- cgit v1.2.3-54-g00ecf