From 8e7bd9636260af3e31997e2ad5ec071c4e7a0153 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Wed, 27 Jul 2022 09:16:50 -0400 Subject: Fix a check, make a netflow padding function more safe. Previously, `channelpadding_get_netflow_inactive_timeout_ms` would crash with an assertion failure if `low_timeout` was greater than `high_timeout`. That wasn't possible in practice because of checks in `channelpadding_update_padding_for_channel`, but it's better not to have a function whose correctness is this tricky to prove. Fixes #40645. Bugfix on 0.3.1.1-alpha. --- changes/bug40645 | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changes/bug40645 (limited to 'changes') diff --git a/changes/bug40645 b/changes/bug40645 new file mode 100644 index 0000000000..044d5b67d2 --- /dev/null +++ b/changes/bug40645 @@ -0,0 +1,5 @@ + o Minor bugfixes (defense in depth): + - Change a test in the netflow padding code to make it more + _obviously_ safe against remotely triggered crashes. + (It was safe against these before, but not obviously so.) + Fixes bug 40645; bugfix on 0.3.1.1-alpha. -- cgit v1.2.3-54-g00ecf