From f455686b77e4ac686251c6edf1f4a506a369866c Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Wed, 12 Jun 2013 12:04:33 -0400 Subject: Unmap the microdescriptor cache before replacing it. This is a reprise of the fix in bdff7e3299d78; 6905c1f6 reintroduced that bug. Briefly: windows doesn't seem to like deleting a mapped file. I tried adding the PROT_SHARED_DELETE flag to the createfile all, but that didn't actually fix this issue. Fortunately, the unit test I added in 4f4fc63fea0589a4fa03f3859dc27860cdde75af should prevent us from making this particular screw-up again. This patch also tries to limit the crash potential of a failure to write by a little bit, although it could do a better job of retaining microdescriptor bodies. Fix for bug 8822, bugfix on 0.2.4.12-alpha. --- changes/bug8822 | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changes/bug8822 (limited to 'changes') diff --git a/changes/bug8822 b/changes/bug8822 new file mode 100644 index 0000000000..c6787afe06 --- /dev/null +++ b/changes/bug8822 @@ -0,0 +1,5 @@ + o Major bugfixes (windows): + - Prevent failures on Windows Vista and later when rebuilding the + microdescriptor cache. Diagnosed by Robert Ransom. Fixes bug 8822; + bugfix on 0.2.4.12-alpha. + -- cgit v1.2.3-54-g00ecf