From 5b03c7ba6d899e19e8f3e0a58bd5df8bb7bbf1d0 Mon Sep 17 00:00:00 2001 From: David Goulet Date: Wed, 2 Aug 2017 13:20:59 -0400 Subject: Fix check_expired_networkstatus_callback() if condition The condition was always true meaning that we would reconsider updating our directory information every 2 minutes. If valid_until is 6am today, then now - 24h == 1pm yesterday which means that "valid_until < (now - 24h)" is false. But at 6:01am tomorrow, "valid_until < (now - 24h)" becomes true which is that point that we shouldn't trust the consensus anymore. Fixes #23091 Signed-off-by: David Goulet --- changes/bug23091 | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 changes/bug23091 (limited to 'changes') diff --git a/changes/bug23091 b/changes/bug23091 new file mode 100644 index 0000000000..7dfb7e4180 --- /dev/null +++ b/changes/bug23091 @@ -0,0 +1,6 @@ + o Minor bugfixes (consensus expiry): + - Tor would reconsider updating its directory information every 2 minutes + instead of only doing it for a consensus that is more than 24 hours old + (badly expired). This specific check is done in the tor main loop + callback that validates if we have an expired consensus. Fixes bug + 23091; bugfix on tor-0.2.0.19-alpha. -- cgit v1.2.3-54-g00ecf