From 32b9edeb91a7d9b9752083622d1ce400f45e42ea Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Tue, 25 Jul 2017 10:14:24 -0400 Subject: Fix build warnings from Coverity related to our BUG macro In the Linux kernel, the BUG() macro causes an instant panic. Our BUG() macro is different, however: it generates a nonfatal assertion failure, and is usable as an expression. Additionally, this patch tells util_bug.h to make all assertion failures into fatal conditions when we're building with a static analysis tool, so that the analysis tool can look for instances where they're reachable. Fixes bug 23030. --- changes/bug23030_029 | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 changes/bug23030_029 (limited to 'changes') diff --git a/changes/bug23030_029 b/changes/bug23030_029 new file mode 100644 index 0000000000..89a1b507d7 --- /dev/null +++ b/changes/bug23030_029 @@ -0,0 +1,7 @@ + o Minor bugfixes (coverity builds): + - Avoid Coverity build warnings related to our BUG() macro. By + default, Coverity treats BUG() as the Linux kernel does: an + instant abort(). We need to override that so our BUG() macro + doesn't prevent Coverity from analyzing functions that use it. + Fixes bug 23030; bugfix on 0.2.9.1-alpha. + -- cgit v1.2.3-54-g00ecf