From cf6e72b7020c47ba20677dc19602663723bd8491 Mon Sep 17 00:00:00 2001 From: David Goulet Date: Tue, 4 May 2021 10:37:26 -0400 Subject: hs: Fix ADD_ONION with client authorization Turns out that passing client authorization keys to ADD_ONION for v3 was not working because we were not setting the "is_client_auth_enabled" flag to true once the clients were configured. This lead to the descriptor being encoded without the clients. This patch removes that flag and instead adds an inline function that can be used to check if a given service has client authorization enabled. This will be much less error prone of needing to keep in sync the client list and a flag instead. Fixes #40378 Signed-off-by: David Goulet --- changes/ticket40378 | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 changes/ticket40378 (limited to 'changes/ticket40378') diff --git a/changes/ticket40378 b/changes/ticket40378 new file mode 100644 index 0000000000..35b2fd7bd4 --- /dev/null +++ b/changes/ticket40378 @@ -0,0 +1,4 @@ + o Major bugfixes (onion service, control port): + - Make the ADD_ONION command properly configure client authorization. Before + this fix, the created onion failed to add the client(s). Fixes bug 40378; + bugfix on 0.4.6.1-alpha. -- cgit v1.2.3-54-g00ecf