From ea339227c27c03d7ced9e526d9e945708f432b22 Mon Sep 17 00:00:00 2001 From: David Goulet Date: Tue, 1 Sep 2020 09:54:48 -0400 Subject: conn: Remove assert on new listener connection when retrying Opening a new listener connection can fail in many ways like a bind() permission denied on a low port for instance. And thus, we should expect to handle an error when creating a new one instead of assert() on it. To hit the removed assert: ORPort 80 KeepBindCapabilities 0 Start tor. Then edit torrc: ORPort :80 HUP tor and the assert is hit. Fixes #40073 Signed-off-by: David Goulet --- changes/ticket40073 | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 changes/ticket40073 (limited to 'changes/ticket40073') diff --git a/changes/ticket40073 b/changes/ticket40073 new file mode 100644 index 0000000000..30b028c042 --- /dev/null +++ b/changes/ticket40073 @@ -0,0 +1,3 @@ + o Minor bugfixes (relay configuration, crash): + - Avoid a fatal assert() when failing to create a listener connection for an + address that was in use. Fixes bug 40073; bugfix on 0.3.5.1-alpha. -- cgit v1.2.3-54-g00ecf