From 81d69f4c2d8a4517d1600c617924dec84228c889 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Mon, 3 Jan 2011 16:54:57 -0500 Subject: Detect signed size_t and report an error at configure time. --- changes/bug2337 | 3 +++ configure.in | 17 +++++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 changes/bug2337 diff --git a/changes/bug2337 b/changes/bug2337 new file mode 100644 index 0000000000..a4f052dc31 --- /dev/null +++ b/changes/bug2337 @@ -0,0 +1,3 @@ + o Minor bugfixes + - Detect broken platforms with a signed size_t, and refuse to + build there. Found and analyzed by doorss and rransom. diff --git a/configure.in b/configure.in index 68c593a11b..394be9e82d 100644 --- a/configure.in +++ b/configure.in @@ -548,6 +548,23 @@ if test "$tor_cv_time_t_signed" != no; then [Define to 1 iff time_t is signed]) fi +AC_CACHE_CHECK([whether size_t is signed], tor_cv_size_t_signed, [ +AC_RUN_IFELSE(AC_LANG_SOURCE([ +#ifdef HAVE_SYS_TYPES_H +#include +#endif +int main(int c, char**v) { if (((size_t)-1)<0) return 1; else return 0; }]), + tor_cv_size_t_signed=no, tor_cv_size_t_signed=yes, tor_cv_size_t_signed=cross) +]) + +if test "$tor_cv_size_t_signed" = cross; then + AC_MSG_NOTICE([Cross compiling: assuming that size_t is not signed.]) +fi + +if test "$tor_cv_size_t_signed" = yes; then + AC_MSG_ERROR([You have a signed size_t; that's grossly nonconformant.]) +fi + AC_CHECK_SIZEOF(socklen_t, , [AC_INCLUDES_DEFAULT() #ifdef HAVE_SYS_SOCKET_H #include -- cgit v1.2.3-54-g00ecf From 2dd7df8308ec962700b1a4311cd675f668631c90 Mon Sep 17 00:00:00 2001 From: Sebastian Hahn Date: Wed, 12 Jan 2011 04:02:24 +0100 Subject: Fix a autoconf warning --- configure.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.in b/configure.in index 394be9e82d..1d1a1794e3 100644 --- a/configure.in +++ b/configure.in @@ -549,11 +549,11 @@ if test "$tor_cv_time_t_signed" != no; then fi AC_CACHE_CHECK([whether size_t is signed], tor_cv_size_t_signed, [ -AC_RUN_IFELSE(AC_LANG_SOURCE([ +AC_RUN_IFELSE([AC_LANG_SOURCE([ #ifdef HAVE_SYS_TYPES_H #include #endif -int main(int c, char**v) { if (((size_t)-1)<0) return 1; else return 0; }]), +int main(int c, char**v) { if (((size_t)-1)<0) return 1; else return 0; }])], tor_cv_size_t_signed=no, tor_cv_size_t_signed=yes, tor_cv_size_t_signed=cross) ]) -- cgit v1.2.3-54-g00ecf