From 9201586ed5fdd7757641ae61e1b3aa2fd7cb9d62 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Sat, 3 Jan 2009 23:06:12 +0000 Subject: Another attempt at fixing coverity scan CID 361. svn:r17863 --- src/or/routerlist.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/or/routerlist.c b/src/or/routerlist.c index a58976a7e9..ddb488df49 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -3295,7 +3295,8 @@ routerlist_remove_old_routers(void) * decide to kill routers.) */ /* XXX021 we don't check if we have a v3 consensus, do we? should we? -RD */ if (!caches || - smartlist_len(networkstatus_v2_list) > get_n_v2_authorities() / 2) { + (networkstatus_v2_list && + smartlist_len(networkstatus_v2_list) > get_n_v2_authorities() / 2)) { cutoff = now - ROUTER_MAX_AGE; /* Remove too-old unrecommended members of routerlist->routers. */ for (i = 0; i < smartlist_len(routerlist->routers); ++i) { -- cgit v1.2.3-54-g00ecf