From 93df26b11a67423e05c200cd93cba6398b9f2a49 Mon Sep 17 00:00:00 2001 From: David Goulet Date: Mon, 5 Aug 2024 11:59:30 -0400 Subject: dirvote: Fix memleak when computing consensus Fixes #40966 Signed-off-by: David Goulet --- changes/ticket40966 | 3 +++ src/feature/dirauth/dirvote.c | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 changes/ticket40966 diff --git a/changes/ticket40966 b/changes/ticket40966 new file mode 100644 index 0000000000..04fb3caded --- /dev/null +++ b/changes/ticket40966 @@ -0,0 +1,3 @@ + o Minor bugfixes (memleak, authority): + - Fix a small memleak when computing a new consensus. This only affects + directory authorities. Fixes bug 40966; bugfix on 0.3.5.1-alpha. diff --git a/src/feature/dirauth/dirvote.c b/src/feature/dirauth/dirvote.c index 1080415827..0783fb1e91 100644 --- a/src/feature/dirauth/dirvote.c +++ b/src/feature/dirauth/dirvote.c @@ -3543,8 +3543,10 @@ dirvote_compute_consensuses(void) { char *filename; tor_asprintf(&filename, "my-consensus-%s", flavor_name); - write_str_to_file(get_datadir_fname(filename), consensus_body, 0); + char *fpath = get_datadir_fname(filename); + write_str_to_file(fpath, consensus_body, 0); tor_free(filename); + tor_free(fpath); } consensus_body = NULL; -- cgit v1.2.3-54-g00ecf