From f3e7d64f5f8193c5b164fcac0ec20747f8bdd738 Mon Sep 17 00:00:00 2001 From: toofar Date: Sun, 16 Jul 2023 23:30:31 +1200 Subject: Do raise a smoke test error on debug builds I don't get it. If you capture the output on a debug build and don't print it what's the point? And why have --debug args in the workflow if debug is supposed to be called from a failure in the non debug build? I feel like I'm missing something here. Hopefully this lets me actually see some output in CI ... --- scripts/dev/build_release.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/dev/build_release.py b/scripts/dev/build_release.py index 6259a72ac..953a2a1be 100755 --- a/scripts/dev/build_release.py +++ b/scripts/dev/build_release.py @@ -238,9 +238,6 @@ def smoke_test(executable: pathlib.Path, debug: bool, qt5: bool) -> None: "", ] - if debug: - print("Not raising smoke test error for debug build") - return raise Exception("\n".join(lines)) # pylint: disable=broad-exception-raised -- cgit v1.2.3-54-g00ecf