From e6ae8797e71a678bef97a13b9057e29442e0ef48 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 4 Jan 2021 19:34:11 +0100 Subject: tests: Make sure QWebEnginePage is deleted early If we use the "webengineview" fixture and access QWebEngineProfile.defaultProfile(), it could happen that the profile outlives the page. In that case, we get a warning on pytest shutdown: Release of profile requested but WebEnginePage still not deleted. Expect troubles ! Thus, let's make sure the page is cleaned up earlier. --- tests/helpers/fixtures.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/helpers/fixtures.py b/tests/helpers/fixtures.py index 6f80099bb..b814a6ea7 100644 --- a/tests/helpers/fixtures.py +++ b/tests/helpers/fixtures.py @@ -444,7 +444,8 @@ def webengineview(qtbot, monkeypatch, web_tab_setup): monkeypatch.setattr(objects, 'backend', usertypes.Backend.QtWebEngine) view = QtWebEngineWidgets.QWebEngineView() qtbot.add_widget(view) - return view + yield view + view.setPage(None) # Avoid warning if using QWebEngineProfile @pytest.fixture -- cgit v1.2.3-54-g00ecf