From db70f34ba3d06d5abe2d0af667cafe0123c80dba Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 22 Dec 2020 19:42:18 +0100 Subject: Use version.MODULE_INFO in test_version --- tests/unit/utils/test_version.py | 23 +++-------------------- 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/tests/unit/utils/test_version.py b/tests/unit/utils/test_version.py index a0aba8bdf..c34ef6e0e 100644 --- a/tests/unit/utils/test_version.py +++ b/tests/unit/utils/test_version.py @@ -553,25 +553,8 @@ class ImportFake: """ def __init__(self): - self.modules = collections.OrderedDict([ - ('sip', True), - ('colorama', True), - ('pypeg2', True), - ('jinja2', True), - ('pygments', True), - ('yaml', True), - ('adblock', True), - ('attr', True), - ('importlib_resources', True), - ('PyQt5.QtWebEngineWidgets', True), - ('PyQt5.QtWebEngine', True), - ('PyQt5.QtWebKitWidgets', True), - ]) - self.no_version_attribute = ['sip', - 'importlib_resources', - 'PyQt5.QtWebEngineWidgets', - 'PyQt5.QtWebKitWidgets', - 'PyQt5.QtWebEngine'] + self.modules = collections.OrderedDict( + [(mod, True) for mod in version.MODULE_INFO]) self.version_attribute = '__version__' self.version = '1.2.3' self._real_import = builtins.__import__ @@ -630,7 +613,7 @@ class TestModuleVersions: """Test with all modules present in version 1.2.3.""" expected = [] for name in import_fake.modules: - if name in import_fake.no_version_attribute: + if '__version__' not in version.MODULE_INFO[name]._version_attributes: expected.append('{}: yes'.format(name)) else: expected.append('{}: 1.2.3'.format(name)) -- cgit v1.2.3-54-g00ecf