From d7738719f394835b4054dfd2f8d9a98b2bc3e48d Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 13 Apr 2021 09:52:26 +0200 Subject: Disable replaceAll quirk by default Fixes #6208 --- doc/changelog.asciidoc | 6 ++++++ doc/help/settings.asciidoc | 5 ++++- qutebrowser/config/configdata.yml | 10 ++++++++-- 3 files changed, 18 insertions(+), 3 deletions(-) diff --git a/doc/changelog.asciidoc b/doc/changelog.asciidoc index 7921864a5..b1b8ae447 100644 --- a/doc/changelog.asciidoc +++ b/doc/changelog.asciidoc @@ -112,6 +112,12 @@ Changed valid, but was never customized. - The `statusbar.widgets` setting now understands `text:...` entries which allows adding a hard-coded text to the statusbar. +- The polyfill for `String.replaceAll` (required for Nextcloud Calendar < 2.2.0 + with QtWebEngine < 5.15.3) is now disabled by default, as it's not fully + compliant to the ECMAScript spec and might cause issues on other websites. + If you still need it (e.g. if you're still on an old Nextcloud Calendar + version), remove `js-string-replaceall` from + `content.site_specific_quirks.skip`. Fixed ~~~~~ diff --git a/doc/help/settings.asciidoc b/doc/help/settings.asciidoc index 463e40fea..d691fdaca 100644 --- a/doc/help/settings.asciidoc +++ b/doc/help/settings.asciidoc @@ -2683,6 +2683,7 @@ Default: +pass:[true]+ [[content.site_specific_quirks.skip]] === content.site_specific_quirks.skip Disable a list of named quirks. +The js-string-replaceall quirk is needed for Nextcloud Calendar < 2.2.0 with QtWebEngine < 5.15.3. However, the workaround is not fully compliant to the ECMAScript spec and might cause issues on other websites, so it's disabled by default. Type: <> @@ -2698,7 +2699,9 @@ Valid values: * +misc-krunker+ * +misc-mathml-darkmode+ -Default: empty +Default: + +- +pass:[js-string-replaceall]+ [[content.tls.certificate_errors]] === content.tls.certificate_errors diff --git a/qutebrowser/config/configdata.yml b/qutebrowser/config/configdata.yml index 65de2772f..6faf1fd0c 100644 --- a/qutebrowser/config/configdata.yml +++ b/qutebrowser/config/configdata.yml @@ -552,8 +552,14 @@ content.site_specific_quirks.skip: - misc-krunker - misc-mathml-darkmode none_ok: true - default: [] - desc: 'Disable a list of named quirks.' + default: ["js-string-replaceall"] + desc: >- + Disable a list of named quirks. + + The js-string-replaceall quirk is needed for Nextcloud Calendar < 2.2.0 with + QtWebEngine < 5.15.3. However, the workaround is not fully compliant to the + ECMAScript spec and might cause issues on other websites, so it's disabled by + default. # emacs: ' -- cgit v1.2.3-54-g00ecf