From c07b93b7c40aef496e8e0a298e4fbafedf4ee8d0 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 18 Mar 2021 10:59:51 +0100 Subject: pylint: Disable pointless-statement in tests --- scripts/dev/run_pylint_on_tests.py | 1 + tests/unit/browser/test_history.py | 3 +-- tests/unit/browser/webkit/test_webkitelem.py | 2 +- tests/unit/config/test_config.py | 6 +++--- tests/unit/config/test_configcache.py | 2 -- 5 files changed, 6 insertions(+), 8 deletions(-) diff --git a/scripts/dev/run_pylint_on_tests.py b/scripts/dev/run_pylint_on_tests.py index 16a281d57..d0385bd17 100644 --- a/scripts/dev/run_pylint_on_tests.py +++ b/scripts/dev/run_pylint_on_tests.py @@ -58,6 +58,7 @@ def main(): 'protected-access', 'len-as-condition', 'compare-to-empty-string', + 'pointless-statement', # directories without __init__.py... 'import-error', ] diff --git a/tests/unit/browser/test_history.py b/tests/unit/browser/test_history.py index 1ca708ec8..1a46c5be0 100644 --- a/tests/unit/browser/test_history.py +++ b/tests/unit/browser/test_history.py @@ -488,12 +488,11 @@ class TestCompletionMetaInfo: def test_contains_keyerror(self, metainfo): with pytest.raises(KeyError): - # pylint: disable=pointless-statement 'does_not_exist' in metainfo # noqa: B015 def test_getitem_keyerror(self, metainfo): with pytest.raises(KeyError): - metainfo['does_not_exist'] # pylint: disable=pointless-statement + metainfo['does_not_exist'] def test_setitem_keyerror(self, metainfo): with pytest.raises(KeyError): diff --git a/tests/unit/browser/webkit/test_webkitelem.py b/tests/unit/browser/webkit/test_webkitelem.py index 33af45b6c..593896e96 100644 --- a/tests/unit/browser/webkit/test_webkitelem.py +++ b/tests/unit/browser/webkit/test_webkitelem.py @@ -303,7 +303,7 @@ class TestWebKitElement: def test_getitem_keyerror(self, elem): with pytest.raises(KeyError): - elem['foo'] # pylint: disable=pointless-statement + elem['foo'] def test_setitem(self, elem): elem['foo'] = 'bar' diff --git a/tests/unit/config/test_config.py b/tests/unit/config/test_config.py index 8a9d8154d..c28e8ce07 100644 --- a/tests/unit/config/test_config.py +++ b/tests/unit/config/test_config.py @@ -725,7 +725,7 @@ class TestContainer: def test_getattr_invalid_private(self, container): """Make sure an invalid _attribute doesn't try getting a container.""" with pytest.raises(AttributeError): - container._foo # pylint: disable=pointless-statement + container._foo def test_getattr_prefix(self, container): new_container = container.tabs @@ -744,7 +744,7 @@ class TestContainer: def test_getattr_invalid(self, container): with pytest.raises(configexc.NoOptionError) as excinfo: - container.tabs.foobar # pylint: disable=pointless-statement + container.tabs.foobar assert excinfo.value.option == 'tabs.foobar' def test_setattr_option(self, config_stub, container): @@ -754,7 +754,7 @@ class TestContainer: def test_confapi_errors(self, container): configapi = types.SimpleNamespace(errors=[]) container._configapi = configapi - container.tabs.foobar # pylint: disable=pointless-statement + container.tabs.foobar assert len(configapi.errors) == 1 error = configapi.errors[0] diff --git a/tests/unit/config/test_configcache.py b/tests/unit/config/test_configcache.py index 6bd841a65..87514bada 100644 --- a/tests/unit/config/test_configcache.py +++ b/tests/unit/config/test_configcache.py @@ -55,12 +55,10 @@ def test_configcache_get_after_set(config_stub): def test_configcache_naive_benchmark(config_stub, benchmark): def _run_bench(): for _i in range(10000): - # pylint: disable=pointless-statement config.cache['tabs.padding'] config.cache['tabs.indicator.width'] config.cache['tabs.indicator.padding'] config.cache['tabs.min_width'] config.cache['tabs.max_width'] config.cache['tabs.pinned.shrink'] - # pylint: enable=pointless-statement benchmark(_run_bench) -- cgit v1.2.3-54-g00ecf