From c02a15b6c7525226a8cea274b0e111d4a6518d54 Mon Sep 17 00:00:00 2001 From: toofar Date: Mon, 27 Nov 2023 08:20:28 +1300 Subject: Cleanup pdfjs_name Now we aren't using it for the patching we don't need it in this function. Move the `get_pdfjs_basename()` call into `is_available()` too since having to call two methods to check everything is there sounds like a pain. --- qutebrowser/browser/pdfjs.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/qutebrowser/browser/pdfjs.py b/qutebrowser/browser/pdfjs.py index 1a13f5bda..4c344d727 100644 --- a/qutebrowser/browser/pdfjs.py +++ b/qutebrowser/browser/pdfjs.py @@ -50,8 +50,7 @@ def generate_pdfjs_page(filename, url): filename: The filename of the PDF to open. url: The URL being opened. """ - pdfjs_name = get_pdfjs_basename() - if pdfjs_name is None or not is_available(): + if not is_available(): pdfjs_dir = os.path.join(standarddir.data(), 'pdfjs') return jinja.render('no_pdfjs.html', url=url.toDisplayString(), @@ -220,7 +219,7 @@ def get_pdfjs_basename(): def is_available(): """Return true if certain parts of a pdfjs installation are available.""" try: - # get_pdfjs_res('build/pdf.mjs') + get_pdfjs_basename() get_pdfjs_res('web/viewer.html') except PDFJSNotFound: return False -- cgit v1.2.3-54-g00ecf