From b91e23457858081ae79a74a953c50a7c9d53e319 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 12 Mar 2021 18:27:50 +0100 Subject: Leave insert mode when clicking devtools 'x' Closes #6270 (cherry picked from commit 579e70b0ab812a5195f726ad41e2d7016e54c7b5) --- qutebrowser/browser/webengine/webengineinspector.py | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/qutebrowser/browser/webengine/webengineinspector.py b/qutebrowser/browser/webengine/webengineinspector.py index 7078954b4..ae31c0bee 100644 --- a/qutebrowser/browser/webengine/webengineinspector.py +++ b/qutebrowser/browser/webengine/webengineinspector.py @@ -28,7 +28,8 @@ from PyQt5.QtWidgets import QWidget from qutebrowser.browser import inspector from qutebrowser.browser.webengine import webenginesettings from qutebrowser.misc import miscwidgets -from qutebrowser.utils import version +from qutebrowser.utils import version, usertypes +from qutebrowser.keyinput import modeman class WebEngineInspectorView(QWebEngineView): @@ -65,7 +66,18 @@ class WebEngineInspector(inspector.AbstractWebInspector): self._settings = webenginesettings.WebEngineSettings(view.settings()) self._set_widget(view) page = view.page() - page.windowCloseRequested.connect(self.hide) # type: ignore[attr-defined] + page.windowCloseRequested.connect( # type: ignore[attr-defined] + self._on_window_close_requested) + + def _on_window_close_requested(self) -> None: + """Called when the 'x' was clicked in the devtools.""" + modeman.leave( + self._win_id, + usertypes.KeyMode.insert, + 'devtools close requested', + maybe=True, + ) + self.hide() def _check_devtools_resources(self) -> None: """Make sure that the devtools resources are available on Fedora. -- cgit v1.2.3-54-g00ecf