From b40e1861c3aaa4b2336b5eff64f0fd2f9fe5b9d2 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 4 Dec 2023 19:46:51 +0100 Subject: Fix lint and tests --- qutebrowser/browser/webengine/webenginesettings.py | 2 +- qutebrowser/config/configdata.yml | 6 ++++-- tests/unit/config/test_qtargs.py | 5 +++-- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/qutebrowser/browser/webengine/webenginesettings.py b/qutebrowser/browser/webengine/webenginesettings.py index 16887b7ba..2b375a7b0 100644 --- a/qutebrowser/browser/webengine/webenginesettings.py +++ b/qutebrowser/browser/webengine/webenginesettings.py @@ -150,7 +150,7 @@ class WebEngineSettings(websettings.AbstractSettings): } try: _ATTRIBUTES['content.canvas_reading'] = Attr( - QWebEngineSettings.WebAttribute.ReadingFromCanvasEnabled) # type: ignore[attr-defined,unused-ignore] + QWebEngineSettings.WebAttribute.ReadingFromCanvasEnabled) # type: ignore[attr-defined,unused-ignore] except AttributeError: # Added in QtWebEngine 6.6 pass diff --git a/qutebrowser/config/configdata.yml b/qutebrowser/config/configdata.yml index ff45b355d..e973fca28 100644 --- a/qutebrowser/config/configdata.yml +++ b/qutebrowser/config/configdata.yml @@ -1035,8 +1035,10 @@ content.javascript.legacy_touch_events: type: name: String valid_values: - - always: Legacy touch events are always enabled. This might cause some websites to assume a mobile device. - - auto: Legacy touch events are only enabled if a touch screen was detected on startup. + - always: Legacy touch events are always enabled. This might cause some + websites to assume a mobile device. + - auto: Legacy touch events are only enabled if a touch screen was + detected on startup. - never: Legacy touch events are always disabled. default: never backend: QtWebEngine diff --git a/tests/unit/config/test_qtargs.py b/tests/unit/config/test_qtargs.py index d8980bb53..d7a95aad1 100644 --- a/tests/unit/config/test_qtargs.py +++ b/tests/unit/config/test_qtargs.py @@ -75,9 +75,10 @@ class TestQtArgs: (['--qt-flag', 'foo', '--qt-flag', 'bar'], [sys.argv[0], '--foo', '--bar']), ]) - def test_qt_args(self, monkeypatch, config_stub, args, expected, parser): + def test_qt_args(self, request, monkeypatch, config_stub, args, expected, parser): """Test commandline with no Qt arguments given.""" - expected.append("--touch-events=disabled") # passed unconditionally + if request.config.webengine: + expected.append("--touch-events=disabled") # passed unconditionally parsed = parser.parse_args(args) assert qtargs.qt_args(parsed) == expected -- cgit v1.2.3-54-g00ecf