From ac84cbaad9b8132e2ca8681938b2c28e192f5930 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 13 Apr 2022 20:54:32 +0200 Subject: Use QFontMetrics::boundingRect() .width() was deprecated in Qt 5.11 because what it actually does is better described as .horizontalAdvance(): https://codereview.qt-project.org/c/qt/qtbase/+/201397 (ee2ad9df701b27790e2ab72e99111d255fde42ed in qtbase) Docs: https://doc.qt.io/qt-6/qfontmetrics.html#horizontalAdvance-2 What we actually want for the size hint is the bounding box. (originally cherry picked from commit 78838338c331d74931da31acd2306550721ef121) --- qutebrowser/mainwindow/statusbar/command.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qutebrowser/mainwindow/statusbar/command.py b/qutebrowser/mainwindow/statusbar/command.py index 92408d34f..199f0a103 100644 --- a/qutebrowser/mainwindow/statusbar/command.py +++ b/qutebrowser/mainwindow/statusbar/command.py @@ -276,7 +276,7 @@ class Command(misc.MinimalLineEditMixin, misc.CommandLineEdit): text = self.text() if not text: text = 'x' - width = self.fontMetrics().width(text) + width = self.fontMetrics().boundingRect(text).width() return QSize(width, height) @pyqtSlot() -- cgit v1.2.3-54-g00ecf