From a71c25c2a092e9c59ed65ac3d21d761a26b447ab Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 5 Jun 2023 13:02:42 +0200 Subject: Make herbe process error non-fatal --- doc/changelog.asciidoc | 1 + qutebrowser/browser/webengine/notification.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/changelog.asciidoc b/doc/changelog.asciidoc index d8d2399a0..cc9ca240d 100644 --- a/doc/changelog.asciidoc +++ b/doc/changelog.asciidoc @@ -168,6 +168,7 @@ Fixed - Crash with some notification servers when the server is quitting. - Crash when using QtWebKit with PAC and the file has an invalid encoding. - Crash with the "tiramisu" notification server. +- Crash when the "herbe" notification presenter doesn't start correctly. [[v2.5.4]] v2.5.4 (2023-03-13) diff --git a/qutebrowser/browser/webengine/notification.py b/qutebrowser/browser/webengine/notification.py index fc47277c3..f91d146d8 100644 --- a/qutebrowser/browser/webengine/notification.py +++ b/qutebrowser/browser/webengine/notification.py @@ -637,7 +637,7 @@ class HerbeNotificationAdapter(AbstractNotificationAdapter): if error == QProcess.ProcessError.Crashed: return name = debug.qenum_key(QProcess.ProcessError, error) - raise Error(f'herbe process error: {name}') + self.error.emit(f'herbe process error: {name}') @pyqtSlot(int) def on_web_closed(self, notification_id: int) -> None: -- cgit v1.2.3-54-g00ecf