From 9cb54b2099a0e884df38e9de24d58b9bef195ca1 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 17 Mar 2023 18:07:13 +0100 Subject: Qt 6.5: Skip elf tests The ELF file structure changed in a way that it seems impossible to support reliably. Given that we have an API to get the version nowadays, let's not bother with this. We might need to figure this out for PySide6 support, but not now. See #7624, #3625 --- tests/unit/misc/test_elf.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/unit/misc/test_elf.py b/tests/unit/misc/test_elf.py index 8a89d11fb..41a5e273d 100644 --- a/tests/unit/misc/test_elf.py +++ b/tests/unit/misc/test_elf.py @@ -47,7 +47,7 @@ def test_format_sizes(fmt, expected): @pytest.mark.skipif(not utils.is_linux, reason="Needs Linux") -def test_result(qapp, caplog): +def test_result(webengine_versions, qapp, caplog): """Test the real result of ELF parsing. NOTE: If you're a distribution packager (or contributor) and see this test failing, @@ -60,6 +60,10 @@ def test_result(qapp, caplog): pytest.importorskip('qutebrowser.qt.webenginecore') versions = elf.parse_webenginecore() + if webengine_versions.webengine == utils.VersionNumber(6, 5): + assert versions is None + pytest.xfail("ELF file structure not supported") + assert versions is not None # No failing mmap -- cgit v1.2.3-54-g00ecf