From 9af8cbfb633a755a70f500e50f1cc4fe68461464 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 8 Apr 2021 19:25:08 +0200 Subject: Fix clicking systray notifications --- qutebrowser/browser/webengine/notification.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qutebrowser/browser/webengine/notification.py b/qutebrowser/browser/webengine/notification.py index 54ab8012e..0f1a59f3f 100644 --- a/qutebrowser/browser/webengine/notification.py +++ b/qutebrowser/browser/webengine/notification.py @@ -466,7 +466,7 @@ class SystrayNotificationAdapter(AbstractNotificationAdapter): @pyqtSlot() def _on_systray_clicked(self) -> None: - self.on_clicked.emit(self.NOTIFICATION_ID) + self.click_id.emit(self.NOTIFICATION_ID) @pyqtSlot(int) def on_web_closed(self, notification_id: int) -> None: -- cgit v1.2.3-54-g00ecf From 54b81cbbd9b824d8e1c1daf6fd4103b0084399df Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 8 Apr 2021 19:29:42 +0200 Subject: notifications: Add more info to padding assert --- qutebrowser/browser/webengine/notification.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qutebrowser/browser/webengine/notification.py b/qutebrowser/browser/webengine/notification.py index 0f1a59f3f..682d64bdc 100644 --- a/qutebrowser/browser/webengine/notification.py +++ b/qutebrowser/browser/webengine/notification.py @@ -1029,7 +1029,7 @@ class DBusNotificationAdapter(AbstractNotificationAdapter): # Source: # https://github.com/dunst-project/dunst/blob/v1.6.1/src/icon.c#L292-L309 padding = bytes_per_line - width * channel_count - assert 0 <= padding < 3, padding + assert 0 <= padding < 3, (padding, bytes_per_line, width, channel_count) size -= padding if padding and self._quirks.no_padded_images: -- cgit v1.2.3-54-g00ecf From 76ee6f392d5587e48041d437e9f9fd98ad2f19ae Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 8 Apr 2021 19:48:29 +0200 Subject: ci: Try working around macOS DMG timeouts --- scripts/dev/Makefile-dmg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/dev/Makefile-dmg b/scripts/dev/Makefile-dmg index 3b1a046df..1545318db 100644 --- a/scripts/dev/Makefile-dmg +++ b/scripts/dev/Makefile-dmg @@ -60,7 +60,7 @@ $(MASTER_DMG): $(WC_DMG) $(addprefix $(SOURCE_DIR)/,$(SOURCE_FILES)) #rm -f "$@" #hdiutil create -srcfolder "$(WC_DIR)" -format UDZO -imagekey zlib-level=9 "$@" -volname "$(NAME) $(VERSION)" -scrub -quiet WC_DEV=`hdiutil info | grep "$(WC_DIR)" | grep "Apple_HFS" | awk '{print $$1}'` && \ - hdiutil detach $$WC_DEV -force -debug + hdiutil detach $$WC_DEV -force -debug || true # timeouts on CI sometimes rm -f "$(MASTER_DMG)" hdiutil convert "$(WC_DMG)" -quiet -format UDZO -imagekey zlib-level=9 -o "$@" rm -rf $(WC_DIR) -- cgit v1.2.3-54-g00ecf From f22ea9b81d5b2aeba21c02eb13786b49f499aff0 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 9 Apr 2021 10:03:47 +0200 Subject: ci: Try additional CodeQL queries --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4d97e2acc..71241fb05 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -190,6 +190,7 @@ jobs: uses: github/codeql-action/init@v1 with: languages: javascript, python + queries: +security-and-quality - name: Perform CodeQL Analysis uses: github/codeql-action/analyze@v1 -- cgit v1.2.3-54-g00ecf