From 83fb5fef860c7b7c6561df7af2213bcd661651b1 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 9 Jun 2021 11:08:04 +0200 Subject: Fix prefers_reduced_motion on Windows See #6530 --- doc/help/settings.asciidoc | 1 + qutebrowser/config/configdata.yml | 3 +++ tests/end2end/test_invocations.py | 6 +++++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/help/settings.asciidoc b/doc/help/settings.asciidoc index 2fc4440a6..90197fddb 100644 --- a/doc/help/settings.asciidoc +++ b/doc/help/settings.asciidoc @@ -2612,6 +2612,7 @@ Default: +pass:[false]+ === content.prefers_reduced_motion Request websites to minimize non-essentials animations and motion. This results in the `prefers-reduced-motion` CSS media query to evaluate to `reduce` (rather than `no-preference`). +On Windows, if this setting is set to False, the system-wide animation setting is considered. This setting requires a restart. diff --git a/qutebrowser/config/configdata.yml b/qutebrowser/config/configdata.yml index 78d9c9bf7..d12741ec4 100644 --- a/qutebrowser/config/configdata.yml +++ b/qutebrowser/config/configdata.yml @@ -541,6 +541,9 @@ content.prefers_reduced_motion: This results in the `prefers-reduced-motion` CSS media query to evaluate to `reduce` (rather than `no-preference`). + On Windows, if this setting is set to False, the system-wide animation + setting is considered. + content.site_specific_quirks: renamed: content.site_specific_quirks.enabled diff --git a/tests/end2end/test_invocations.py b/tests/end2end/test_invocations.py index 971be903c..b860feed0 100644 --- a/tests/end2end/test_invocations.py +++ b/tests/end2end/test_invocations.py @@ -757,7 +757,11 @@ def test_dark_mode_mathml(quteproc_new, request, qtbot): ('true', 'Reduced motion'), ('false', 'No'), ]) -def test_prefers_reduced_motion(quteproc_new, request, qtbot, value, preference): +@pytest.mark.skipif( + utils.is_windows, + reason="Outcome on Windows depends on system settings", +) +def test_prefers_reduced_motion(quteproc_new, request, value, preference): if not request.config.webengine: pytest.skip("Skipped with QtWebKit") -- cgit v1.2.3-54-g00ecf