From 734503cf2862012cf3b61411e0469ef2f072f80d Mon Sep 17 00:00:00 2001 From: toofar Date: Fri, 9 Feb 2024 15:32:57 +1300 Subject: Wait for all tabs to be loaded after loading sessions I got a failure in CI on windows for the "Load a collapsed subtree" where it got an index error when trying to load the active history entry for a tab in a session. This is likely because the session was saved before the tab was loaded. I can reproduce it locally by changing the last test to wait for only the first tab, instead of the last. --- tests/end2end/features/treetabs.feature | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/end2end/features/treetabs.feature b/tests/end2end/features/treetabs.feature index 898f9e21a..27bc72fa4 100644 --- a/tests/end2end/features/treetabs.feature +++ b/tests/end2end/features/treetabs.feature @@ -47,6 +47,8 @@ Feature: Tree tab management # Now actually load the saved session And I run :session-save foo And I run :session-load -c foo + And I wait until data/numbers/1.txt is loaded + And I wait until data/numbers/2.txt is loaded And I wait until data/numbers/3.txt is loaded # And of course the same assertion as above too Then the following tabs should be open: @@ -80,6 +82,9 @@ Feature: Tree tab management And I set tabs.new_position.tree.new_child to last And I set tabs.new_position.tree.new_toplevel to prev And I run :session-load -c foo + And I wait until data/numbers/1.txt is loaded + And I wait until data/numbers/2.txt is loaded + And I wait until data/numbers/3.txt is loaded And I wait until data/numbers/4.txt is loaded Then the following tabs should be open: - data/numbers/1.txt -- cgit v1.2.3-54-g00ecf