From 543390c47afab6b68d340bc2c2569485ce1a91f7 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 2 Dec 2021 18:05:34 +0100 Subject: pylint: Work around some minor false-positives See #6857 --- qutebrowser/completion/completer.py | 2 +- qutebrowser/misc/lineparser.py | 1 + tests/unit/mainwindow/statusbar/test_textbase.py | 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/qutebrowser/completion/completer.py b/qutebrowser/completion/completer.py index 778333854..fb61e48fb 100644 --- a/qutebrowser/completion/completer.py +++ b/qutebrowser/completion/completer.py @@ -39,7 +39,7 @@ class CompletionInfo: """Context passed into all completion functions.""" config: config.Config - keyconf: config.KeyConfig + keyconf: config.KeyConfig # pylint: disable=undefined-variable win_id: int cur_tab: 'browsertab.AbstractTab' diff --git a/qutebrowser/misc/lineparser.py b/qutebrowser/misc/lineparser.py index 9d35692e9..fee87354f 100644 --- a/qutebrowser/misc/lineparser.py +++ b/qutebrowser/misc/lineparser.py @@ -99,6 +99,7 @@ class BaseLineParser(QObject): self._opened = True try: if self._binary: + # pylint: disable=unspecified-encoding with open(self._configfile, mode + 'b') as f: yield f else: diff --git a/tests/unit/mainwindow/statusbar/test_textbase.py b/tests/unit/mainwindow/statusbar/test_textbase.py index 631c6ce44..33c4ffd76 100644 --- a/tests/unit/mainwindow/statusbar/test_textbase.py +++ b/tests/unit/mainwindow/statusbar/test_textbase.py @@ -79,11 +79,11 @@ def test_text_elide_none(mocker, qtbot): label = TextBase() qtbot.add_widget(label) label.setText('') - mocker.patch('qutebrowser.mainwindow.statusbar.textbase.TextBase.' - 'fontMetrics') + mock = mocker.patch( + 'qutebrowser.mainwindow.statusbar.textbase.TextBase.fontMetrics') label._update_elided_text(20) - assert not label.fontMetrics.called + assert not mock.called def test_unset_text(qtbot): -- cgit v1.2.3-54-g00ecf