From 346819b2945a8ae0e63c7ac0a28428faf79aad43 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 8 Aug 2023 14:36:48 +0200 Subject: notifications: Handle org.freedesktop.DBus.Error.ServiceUnknown --- doc/changelog.asciidoc | 4 ++++ qutebrowser/browser/webengine/notification.py | 3 +++ 2 files changed, 7 insertions(+) diff --git a/doc/changelog.asciidoc b/doc/changelog.asciidoc index d48e51e0d..b2b392a4c 100644 --- a/doc/changelog.asciidoc +++ b/doc/changelog.asciidoc @@ -202,12 +202,16 @@ Fixed - Crash when using QtWebKit with PAC and the file has an invalid encoding. - Crash with the "tiramisu" notification server. - Crash when the "herbe" notification presenter doesn't start correctly. +- Crash when no notification server is installed/available. - Warning with recent versions of the "deadd" (aka "linux notification center") notification server. - Crash when using `:print --pdf` with a directory where its parent directory did not exist. - The `PyQt{5,6}.sip` version is now shown correctly in the :version|--version output. Previously that showed the version from the standalone `sip` module which was only set for PyQt5. (#7805) +- When a `config.py` calls `.redirect()` via a request interceptor (which is + unsupported) and supplies an invalid redirect target URL, an exception is now + raised for the `.redirect()` call instead of later inside qutebrowser. [[v2.5.4]] v2.5.4 (2023-03-13) diff --git a/qutebrowser/browser/webengine/notification.py b/qutebrowser/browser/webengine/notification.py index 6cc9cc074..e8b2e27f1 100644 --- a/qutebrowser/browser/webengine/notification.py +++ b/qutebrowser/browser/webengine/notification.py @@ -113,6 +113,9 @@ class DBusError(Error): # https://crashes.qutebrowser.org/view/de62220a # after "Notification daemon did quit!" "org.freedesktop.DBus.Error.UnknownObject", + + # notmuch-sha1-ef7b6e9e79e5f2f6cba90224122288895c1fe0d8 + "org.freedesktop.DBus.Error.ServiceUnknown", } def __init__(self, msg: QDBusMessage) -> None: -- cgit v1.2.3-54-g00ecf