From 318e3e709ebef2377910bbeff71d94a7114f3292 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 25 Sep 2023 18:05:35 +0200 Subject: Skip test_real_chromium_version on newer Qt versions Is wrong on unstable Archlinux env when Qt is newer than PyQt. But no need for this when we have the API anyways. (cherry picked from commit a6171337f956048daa8e72745b755a40b607a4f4) --- tests/unit/utils/test_version.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/unit/utils/test_version.py b/tests/unit/utils/test_version.py index 486270d70..586e86e54 100644 --- a/tests/unit/utils/test_version.py +++ b/tests/unit/utils/test_version.py @@ -989,6 +989,16 @@ class TestWebEngineVersions: def test_real_chromium_version(self, qapp): """Compare the inferred Chromium version with the real one.""" + try: + from qutebrowser.qt.webenginecore import ( + qWebEngineVersion, + qWebEngineChromiumVersion, + ) + except ImportError: + pass + else: + pytest.skip("API available to get the real version") + pyqt_webengine_version = version._get_pyqt_webengine_qt_version() if pyqt_webengine_version is None: if '.dev' in PYQT_VERSION_STR: -- cgit v1.2.3-54-g00ecf