From cc03029de1ba18a045cc6d69fd98970678e96948 Mon Sep 17 00:00:00 2001 From: JingMatrix Date: Thu, 3 Mar 2022 16:26:07 +0100 Subject: Qt6 WebEnginePage creatWindow api change When double-clicking a network resource in the devtools, one get AttributeError: 'WebEnginePage' object has no attribute 'view'. --- qutebrowser/browser/webengine/webengineinspector.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qutebrowser/browser/webengine/webengineinspector.py b/qutebrowser/browser/webengine/webengineinspector.py index bb19ef153..694e7f092 100644 --- a/qutebrowser/browser/webengine/webengineinspector.py +++ b/qutebrowser/browser/webengine/webengineinspector.py @@ -50,7 +50,8 @@ class WebEngineInspectorView(QWebEngineView): See WebEngineView.createWindow for details. """ - return self.page().inspectedPage().view().createWindow(wintype) + newpage = self.page().inspectedPage().createWindow(wintype) + return self.forPage(newpage) class WebEngineInspector(inspector.AbstractWebInspector): -- cgit v1.2.3-54-g00ecf From 93da6b9f8b78a43831e676df683f1e1418f3fd2e Mon Sep 17 00:00:00 2001 From: JingMatrix Date: Fri, 4 Mar 2022 02:54:27 +0100 Subject: Avoid confusion by static method forPage() Follow the advice in #7049 --- qutebrowser/browser/webengine/webengineinspector.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qutebrowser/browser/webengine/webengineinspector.py b/qutebrowser/browser/webengine/webengineinspector.py index 694e7f092..91254bd57 100644 --- a/qutebrowser/browser/webengine/webengineinspector.py +++ b/qutebrowser/browser/webengine/webengineinspector.py @@ -27,7 +27,7 @@ from PyQt6.QtWebEngineCore import QWebEnginePage from PyQt6.QtWidgets import QWidget from qutebrowser.browser import inspector -from qutebrowser.browser.webengine import webenginesettings +from qutebrowser.browser.webengine import webenginesettings, webview from qutebrowser.misc import miscwidgets from qutebrowser.utils import version, usertypes from qutebrowser.keyinput import modeman @@ -51,7 +51,7 @@ class WebEngineInspectorView(QWebEngineView): See WebEngineView.createWindow for details. """ newpage = self.page().inspectedPage().createWindow(wintype) - return self.forPage(newpage) + return webview.WebEngineView.forPage(newpage) class WebEngineInspector(inspector.AbstractWebInspector): -- cgit v1.2.3-54-g00ecf