From 09f28f24c64ccbc88570741b37beda9a42e5ff2a Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 20 Jul 2023 12:42:29 +0200 Subject: Fix lint --- qutebrowser/browser/browsertab.py | 2 +- qutebrowser/misc/split.py | 4 ++-- qutebrowser/utils/log.py | 2 +- qutebrowser/utils/qtutils.py | 1 + qutebrowser/utils/version.py | 2 +- 5 files changed, 6 insertions(+), 5 deletions(-) diff --git a/qutebrowser/browser/browsertab.py b/qutebrowser/browser/browsertab.py index eacd61dbb..6f68956f8 100644 --- a/qutebrowser/browser/browsertab.py +++ b/qutebrowser/browser/browsertab.py @@ -294,7 +294,7 @@ class AbstractPrinting(QObject): def show_dialog(self) -> None: """Print with a QPrintDialog.""" - self._dialog = dialog = QPrintDialog(self._tab) + self._dialog = QPrintDialog(self._tab) self._dialog.open(self._do_print) # Gets cleaned up in on_printing_finished diff --git a/qutebrowser/misc/split.py b/qutebrowser/misc/split.py index 0aac9005c..abdfd0eba 100644 --- a/qutebrowser/misc/split.py +++ b/qutebrowser/misc/split.py @@ -201,10 +201,10 @@ def simple_split(s, keep=False, maxsplit=None): if keep: pattern = '([' + whitespace + '])' - parts = re.split(pattern, s, maxsplit) + parts = re.split(pattern, s, maxsplit=maxsplit) return _combine_ws(parts, whitespace) else: pattern = '[' + whitespace + ']' - parts = re.split(pattern, s, maxsplit) + parts = re.split(pattern, s, maxsplit=maxsplit) parts[-1] = parts[-1].rstrip() return [p for p in parts if p] diff --git a/qutebrowser/utils/log.py b/qutebrowser/utils/log.py index 174a599ed..5ac150702 100644 --- a/qutebrowser/utils/log.py +++ b/qutebrowser/utils/log.py @@ -255,7 +255,7 @@ def disable_qt_msghandler() -> Iterator[None]: @contextlib.contextmanager -def py_warning_filter( +def py_warning_filter( action: Literal['default', 'error', 'ignore', 'always', 'module', 'once'] = 'ignore', **kwargs: Any, diff --git a/qutebrowser/utils/qtutils.py b/qutebrowser/utils/qtutils.py index 975503f85..beebcc5c2 100644 --- a/qutebrowser/utils/qtutils.py +++ b/qutebrowser/utils/qtutils.py @@ -651,6 +651,7 @@ def extract_enum_val(val: Union[sip.simplewrapper, int, enum.Enum]) -> int: return int(val) # type: ignore[call-overload] return val + _T = TypeVar("_T") diff --git a/qutebrowser/utils/version.py b/qutebrowser/utils/version.py index 358e8e19b..43d6e4d06 100644 --- a/qutebrowser/utils/version.py +++ b/qutebrowser/utils/version.py @@ -32,7 +32,7 @@ import getpass import functools import dataclasses import importlib.metadata -from typing import (Mapping, Optional, Sequence, Tuple, ClassVar, Dict, cast, Any, +from typing import (Mapping, Optional, Sequence, Tuple, ClassVar, Dict, Any, TYPE_CHECKING) from qutebrowser.qt import machinery -- cgit v1.2.3-54-g00ecf