From 08e1b987bfad53d51fac6a3e3808056c55720ed6 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 30 May 2022 13:44:30 +0200 Subject: Remove setting Pulseaudio properties The icon change doesn't seem to have any effect anymore (those environment variables might be isolated from Chromium rendering processes since some Qt update). The name change isn't needed anymore with QtWebEngine 5.15.2 which is now the oldest supported version. See #3832 --- qutebrowser/app.py | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/qutebrowser/app.py b/qutebrowser/app.py index a241db988..778ff49c0 100644 --- a/qutebrowser/app.py +++ b/qutebrowser/app.py @@ -149,7 +149,6 @@ def init(*, args: argparse.Namespace) -> None: quitter.instance.shutting_down.connect(QApplication.closeAllWindows) _init_icon() - _init_pulseaudio() loader.init() loader.load_components() @@ -195,23 +194,6 @@ def _init_icon(): objects.qapp.setWindowIcon(icon) -def _init_pulseaudio(): - """Set properties for PulseAudio. - - WORKAROUND for https://bugreports.qt.io/browse/QTBUG-85363 - - Affected Qt versions: - - Older than 5.11 (which is unsupported) - - 5.14.0 to 5.15.0 (inclusive) - - However, we set this on all versions so that qutebrowser's icon gets picked - up as well. - """ - # FIXME:qt6 check if this is still needed - for prop in ['application.name', 'application.icon_name']: - os.environ['PULSE_PROP_OVERRIDE_' + prop] = 'qutebrowser' - - def _process_args(args): """Open startpage etc. and process commandline args.""" if not args.override_restore: -- cgit v1.2.3-54-g00ecf