From 03a49419e86fb83077e0c1f75a568bb65d5c9aaf Mon Sep 17 00:00:00 2001 From: toofar Date: Sat, 6 Jan 2024 12:21:39 +1300 Subject: Check the correct tab is pinned when closing When recursive closing a tree group you will be prompted if you want to close any tabs that are pinned. Except we passed the topmost tab to the prompt method every time instead of the tab we were going to close. This fixes that. It does mean that if there are multiple pinned tabs in a tree it gives you an identical prompt for each one, which no indication that they are separate prompts. It looks like nothing is happening when you answer it. But that's a separate problem (probably the solution is to either prompt once or to put URLs and/or tab IDs in the prompt). --- qutebrowser/browser/commands.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qutebrowser/browser/commands.py b/qutebrowser/browser/commands.py index 7a375515a..09f834503 100644 --- a/qutebrowser/browser/commands.py +++ b/qutebrowser/browser/commands.py @@ -282,7 +282,7 @@ class CommandDispatcher: close = functools.partial(self._tab_close, descendent.value, prev, next_, opposite, new_undo) - tabbed_browser.tab_close_prompt_if_pinned(tab, force, + tabbed_browser.tab_close_prompt_if_pinned(descendent.value, force, close) new_undo = False else: -- cgit v1.2.3-54-g00ecf