From 3c76f3403d32d6ecd1c4eedc6283e530af580dd6 Mon Sep 17 00:00:00 2001 From: Micah Lee Date: Tue, 13 Apr 2021 18:28:00 -0400 Subject: Add tooltips to tabs, so you can tell what even long titles are --- desktop/src/onionshare/tab/mode/mode_settings_widget.py | 8 +++----- desktop/src/onionshare/tab_widget.py | 7 ++++++- 2 files changed, 9 insertions(+), 6 deletions(-) (limited to 'desktop') diff --git a/desktop/src/onionshare/tab/mode/mode_settings_widget.py b/desktop/src/onionshare/tab/mode/mode_settings_widget.py index f93f37bf..777987a8 100644 --- a/desktop/src/onionshare/tab/mode/mode_settings_widget.py +++ b/desktop/src/onionshare/tab/mode/mode_settings_widget.py @@ -236,11 +236,9 @@ class ModeSettingsWidget(QtWidgets.QWidget): elif self.tab_mode == None: pass else: - self.settings.set("general", "title", self.title_lineedit.text()) - shortened_title = self.title_lineedit.text() - if len(shortened_title) > 11: - shortened_title = shortened_title[:10] + "..." - self.tab.change_title.emit(self.tab.tab_id, shortened_title) + title = self.title_lineedit.text() + self.settings.set("general", "title", title) + self.tab.change_title.emit(self.tab.tab_id, title) def persistent_checkbox_clicked(self): self.settings.set("persistent", "enabled", self.persistent_checkbox.isChecked()) diff --git a/desktop/src/onionshare/tab_widget.py b/desktop/src/onionshare/tab_widget.py index 3df924d3..a955ea53 100644 --- a/desktop/src/onionshare/tab_widget.py +++ b/desktop/src/onionshare/tab_widget.py @@ -188,8 +188,13 @@ class TabWidget(QtWidgets.QTabWidget): self.bring_to_front.emit() def change_title(self, tab_id, title): + shortened_title = title + if len(shortened_title) > 11: + shortened_title = shortened_title[:10] + "..." + index = self.indexOf(self.tabs[tab_id]) - self.setTabText(index, title) + self.setTabText(index, shortened_title) + self.setTabToolTip(index, title) def change_icon(self, tab_id, icon_path): index = self.indexOf(self.tabs[tab_id]) -- cgit v1.2.3-54-g00ecf