From 687f2acf6ae00226e8304e15f156f36e19ac971f Mon Sep 17 00:00:00 2001 From: Keith Randall Date: Tue, 17 Aug 2021 10:40:44 -0700 Subject: cmd/compile: only use dictionaries for conversions to type parameters Conversions to regular concrete types should not be rewritten during stenciling. Fixes #47740 Change-Id: I2b45e22f962dcd2e18bd6cc876ebc0f850860822 Reviewed-on: https://go-review.googlesource.com/c/go/+/342989 Trust: Keith Randall Trust: Dan Scales Trust: Cuong Manh Le Run-TryBot: Keith Randall TryBot-Result: Go Bot Reviewed-by: Dan Scales --- test/typeparam/issue47740.go | 37 +++++++++++++++++++++++++++++++++++++ test/typeparam/issue47740.out | 2 ++ test/typeparam/issue47740b.go | 23 +++++++++++++++++++++++ 3 files changed, 62 insertions(+) create mode 100644 test/typeparam/issue47740.go create mode 100644 test/typeparam/issue47740.out create mode 100644 test/typeparam/issue47740b.go (limited to 'test') diff --git a/test/typeparam/issue47740.go b/test/typeparam/issue47740.go new file mode 100644 index 0000000000..a8c6839de3 --- /dev/null +++ b/test/typeparam/issue47740.go @@ -0,0 +1,37 @@ +// run -gcflags=-G=3 + +// Copyright 2021 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package main + +import "fmt" + +type Exp[Ty any] interface { + Eval() Ty +} + +type Lit[Ty any] Ty + +func (lit Lit[Ty]) Eval() Ty { return Ty(lit) } +func (lit Lit[Ty]) String() string { return fmt.Sprintf("(lit %v)", Ty(lit)) } + +type Eq[Ty any] struct { + a Exp[Ty] + b Exp[Ty] +} + +func (e Eq[Ty]) String() string { + return fmt.Sprintf("(eq %v %v)", e.a, e.b) +} + +var ( + e0 = Eq[int]{Lit[int](128), Lit[int](64)} + e1 = Eq[bool]{Lit[bool](true), Lit[bool](true)} +) + +func main() { + fmt.Printf("%v\n", e0) + fmt.Printf("%v\n", e1) +} diff --git a/test/typeparam/issue47740.out b/test/typeparam/issue47740.out new file mode 100644 index 0000000000..f23c310f66 --- /dev/null +++ b/test/typeparam/issue47740.out @@ -0,0 +1,2 @@ +(eq (lit 128) (lit 64)) +(eq (lit true) (lit true)) diff --git a/test/typeparam/issue47740b.go b/test/typeparam/issue47740b.go new file mode 100644 index 0000000000..2a91d35eb4 --- /dev/null +++ b/test/typeparam/issue47740b.go @@ -0,0 +1,23 @@ +// run -gcflags=-G=3 + +// Copyright 2021 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package main + +import "reflect" + +type S[T any] struct { + a interface{} +} + +func (e S[T]) M() { + v := reflect.ValueOf(e.a) + _, _ = v.Interface().(int) +} + +func main() { + e := S[int]{0} + e.M() +} -- cgit v1.2.3-54-g00ecf