From c20b7a072a438d9dd806f2e075e029d1d2b0deec Mon Sep 17 00:00:00 2001 From: Dmitri Shuralyov Date: Fri, 12 May 2023 13:00:45 -0400 Subject: cmd/dist: use registerStdTestSpecially for normal Go tests only It was my oversight in CL 463276 to skip registerStdTestSpecially packages in the race bench test registration loop. Package testdir has no benchmarks and doesn't need to be skipped. (And if it had benchmarks, it's very unlikely they'd need any special handling.) By now there are more cmd/cgo/internal/... packages that are registered specially, and there isn't a need for their few benchmarks not to be used for the purpose of race bench tests. If the 3 benchmarks in cmd/cgo/internal/test were to require something special, then we can add it to a new registerRaceBenchTestSpecially map with a comment, and do register them specially in registerTests instead of forgetting to. This restores the automatic 'go_test_bench:cmd/cgo/internal/test' registration and reduces prevalence of registerStdTestSpecially a bit. For #37486. For #56844. Change-Id: I1791fe5bf94cb4b4e0859c5fff4e7a3d5a23723e Reviewed-on: https://go-review.googlesource.com/c/go/+/494656 Reviewed-by: Dmitri Shuralyov TryBot-Result: Gopher Robot Auto-Submit: Dmitri Shuralyov Reviewed-by: Bryan Mills Run-TryBot: Dmitri Shuralyov --- src/cmd/dist/test.go | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/cmd/dist/test.go') diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 1d8125c51d..31265d6eca 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -584,9 +584,6 @@ func (t *tester) registerTests() { } if t.race { for _, pkg := range pkgs { - if registerStdTestSpecially[pkg] { - continue - } if t.packageHasBenchmarks(pkg) { t.registerRaceBenchTest(pkg) } -- cgit v1.2.3-54-g00ecf