From b679e31cdbf09658388795c7b15c64fce86d6bd2 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Wed, 10 May 2023 15:51:41 -0400 Subject: test/bench: delete Russ added test/bench/go1 in CL 5484071 to have a stable suite of programs to use as benchmarks. For the compiler and runtime we had back then, those were reasonable benchmarks, but the compiler and runtime are now far more sophisticated and these benchmarks no longer have good coverage. We also now have better benchmark suites maintained outside the repo (e.g., golang.org/x/benchmarks). Keeping test/bench/go1 at this point is actively misleading. Indirectly related to #37486, as this also removes the last package dist test runs outside of src/. Change-Id: I2867ef303fe48a02acce58ace4ee682add8acdbf Reviewed-on: https://go-review.googlesource.com/c/go/+/494193 Run-TryBot: Austin Clements Reviewed-by: Cherry Mui Reviewed-by: Russ Cox TryBot-Result: Gopher Robot --- src/cmd/dist/test.go | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/cmd/dist/test.go') diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 7ec10aecac..9cb640737a 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -851,11 +851,6 @@ func (t *tester) registerTests() { } } - if goos != "android" && !t.iOS() { - // There are no tests in this directory, only benchmarks. - // Check that the test binary builds. - t.registerTest("bench_go1", "", &goTest{dir: "../test/bench/go1"}) - } if goos != "android" && !t.iOS() { // Only start multiple test dir shards on builders, // where they get distributed to multiple machines. -- cgit v1.2.3-54-g00ecf